Skip to content

Commit a282327

Browse files
committed
review feedback
1 parent a67496e commit a282327

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

internal/cmd/network/describe/describe.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,8 @@ func outputResult(p *print.Printer, outputFormat string, network *iaas.Network)
9797
}
9898
return p.OutputResult(outputFormat, network, func() error {
9999
// IPv4
100-
var ipv4Nameservers []string
101-
var ipv4Prefixes []string
102-
var publicIp *string
103-
var ipv4Gateway *string
100+
var ipv4Nameservers, ipv4Prefixes []string
101+
var publicIp, ipv4Gateway *string
104102
if ipv4 := network.Ipv4; ipv4 != nil {
105103
if ipv4.Nameservers != nil {
106104
ipv4Nameservers = append(ipv4Nameservers, *ipv4.Nameservers...)
@@ -117,8 +115,7 @@ func outputResult(p *print.Printer, outputFormat string, network *iaas.Network)
117115
}
118116

119117
// IPv6
120-
var ipv6Nameservers []string
121-
var ipv6Prefixes []string
118+
var ipv6Nameservers, ipv6Prefixes []string
122119
var ipv6Gateway *string
123120
if ipv6 := network.Ipv6; ipv6 != nil {
124121
if ipv6.Nameservers != nil {

internal/cmd/network/list/list.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,7 @@ func outputResult(p *print.Printer, outputFormat string, networks []iaas.Network
143143
table.SetHeader("ID", "NAME", "STATUS", "PUBLIC IP", "PREFIXES", "ROUTED")
144144

145145
for _, network := range networks {
146-
var publicIp string
147-
var prefixes string
146+
var publicIp, prefixes string
148147
if ipv4 := network.Ipv4; ipv4 != nil {
149148
publicIp = utils.PtrString(ipv4.PublicIp)
150149
prefixes = utils.JoinStringPtr(ipv4.Prefixes, ", ")

0 commit comments

Comments
 (0)