Skip to content

Commit 725bc23

Browse files
committed
Merge remote-tracking branch 'origin/main' into unittests
2 parents 4ab144f + 5d53da0 commit 725bc23

File tree

4 files changed

+58
-15
lines changed

4 files changed

+58
-15
lines changed

.github/dependabot.yml

+33-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,37 @@ updates:
1313
groups:
1414
github-actions:
1515
patterns: ["*"]
16+
labels:
17+
- automation
18+
- gha-update
1619

17-
# TODO: Add web app python dependencies
20+
# Automatically propose PRs for Python dependencies
21+
- package-ecosystem: pip
22+
directories:
23+
- "/web-apps"
24+
- "/scripts"
25+
schedule:
26+
# Check for new versions daily
27+
interval: weekly
28+
groups:
29+
pip-updates:
30+
patterns: ["*"]
31+
labels:
32+
- automation
33+
- pip-update
34+
commit-message:
35+
# Prefix all commit messages with "pip: "
36+
prefix: "pip"
37+
38+
# Automatically propose PRs for Python dependencies
39+
# Possibly required for Helm updates?
40+
# https://github.com/dependabot/dependabot-core/issues/2237
41+
# enable-beta-ecosystems: true
42+
- package-ecosystem: "helm"
43+
directory: "/charts/azimuth-llm" # Location of package manifests
44+
schedule:
45+
# Check for new versions daily
46+
interval: weekly
47+
labels:
48+
- automation
49+
- helm-update

.github/workflows/test-pr.yml

+23-12
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: Test pull request
33

44
on:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -29,7 +29,13 @@ jobs:
2929
needs: [fail_on_remote]
3030
uses: ./.github/workflows/build-push-images.yml
3131
with:
32-
ref: ${{ github.event.pull_request.head.sha }}
32+
ref: ${{ github.sha }}
33+
secrets: inherit
34+
35+
publish_charts:
36+
uses: ./.github/workflows/build-push-charts.yml
37+
with:
38+
ref: ${{ github.sha }}
3339
secrets: inherit
3440

3541
chart_validation:
@@ -42,11 +48,23 @@ jobs:
4248
- name: Checkout the repo
4349
uses: actions/checkout@v4
4450
with:
45-
ref: ${{ github.event.pull_request.head.sha }}
51+
ref: ${{ github.sha }}
52+
53+
- name: Reconfigure docker storage
54+
# GitHub runners have an extra 75G disk at /mnt
55+
# so we use this to avoid hitting capacity issues
56+
# with kind cluster + vLLM container images
57+
run: |
58+
sudo bash -c 'cat > /etc/docker/daemon.json' << EOF
59+
{
60+
"data-root": "/mnt/docker-data"
61+
}
62+
EOF
63+
sudo systemctl restart docker
4664
4765
- name: Run Gradio app tests
4866
run: |
49-
./test-images.sh $(git rev-parse --short ${{ github.event.pull_request.head.sha }})
67+
./test-images.sh $(git rev-parse --short ${{ github.sha }})
5068
working-directory: web-apps
5169

5270
- name: Install Helm
@@ -71,18 +89,11 @@ jobs:
7189
# we need to pull these published images and load them into the kind cluster
7290
# with the tag correct tag.
7391
- name: Load tagged container images into kind cluster
74-
run: ./kind-images.sh $(git rev-parse --short ${{ github.event.pull_request.head.sha }}) ${{ env.CLUSTER_NAME }}
92+
run: ./kind-images.sh $(git rev-parse --short ${{ github.sha }}) ${{ env.CLUSTER_NAME }}
7593
working-directory: web-apps
7694

7795
# https://github.com/helm/charts/blob/master/test/README.md#providing-custom-test-values
7896
# Each chart/ci/*-values.yaml file will be treated as a separate test case with it's
7997
# own helm install/test process.
8098
- name: Run chart install and test
8199
run: ct install --config ct.yaml
82-
83-
publish_charts:
84-
needs: [chart_validation]
85-
uses: ./.github/workflows/build-push-charts.yml
86-
with:
87-
ref: ${{ github.event.pull_request.head.sha }}
88-
secrets: inherit

.github/workflows/update-dependencies.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
6262
- name: Create Pull Request
6363
if: ${{ steps.dependency_updates.outputs.new_vllm_tag }}
64-
uses: peter-evans/create-pull-request@v6
64+
uses: peter-evans/create-pull-request@v7
6565
with:
6666
base: main
6767
branch: update/vllm-${{ steps.dependency_updates.outputs.new_vllm_tag }}

web-apps/chat/app.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def build_chat_context(latest_message, history):
6868
context = []
6969
if INCLUDE_SYSTEM_PROMPT:
7070
context.append(SystemMessage(content=settings.model_instruction))
71-
else:
71+
elif history and len(history) > 0:
7272
# Mimic system prompt by prepending it to first human message
7373
history[0]['content'] = f"{settings.model_instruction}\n\n{history[0]['content']}"
7474

0 commit comments

Comments
 (0)