Skip to content

Commit 262d12b

Browse files
committed
fix prometheus role comments
1 parent 679e1f8 commit 262d12b

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

ansible/roles/prometheus/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@
22
Creates a systemd service `prometheus` which uses the `podman` user to run a containerised [Prometheus](https://github.com/prometheus/prometheus) monitoring system.
33

44
Note this contains two task books:
5-
- `install.yml`: This is safe to run during a Packer build. It pulls the container and creates the systemd unit file.
5+
- `install.yml`: This is safe to run during a Packer build. It pulls the container image and creates the systemd unit file.
66
- `runtime.yml`: This cannot be run during a Packer build. It templates out config and restarts/starts the service as required.
77

8-
## TODO
9-
- Check upgrading clusters from cloudalchemy.prometheus role works OK. The state dir will be owned by `prometheus` user, not `podman`, but this role should fix that.
10-
118
## Role Variables
129

1310
See `defaults/main.yml`. All variables can be updated by running `runtime.yml`, except the below which require `install.yml` to be run to update:

ansible/roles/prometheus/tasks/install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
podman_service_volumes:
1818
- "{{ prometheus_config_dir }}:/etc/prometheus/:U,ro"
1919
- "{{ prometheus_db_dir }}:/prometheus:U"
20-
podman_service_command: | # TODO: make retention time/size runtime configurable (can't be specified in config yml)
20+
podman_service_command: |
2121
--config.file=/etc/prometheus/prometheus.yml \
2222
--storage.tsdb.path=/prometheus \
2323
--web.console.libraries=/usr/share/prometheus/console_libraries \

0 commit comments

Comments
 (0)