-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of managing TLS certificate lifetime #353
Comments
@Jimvin what docs exactly are you referring to? The documentation for the feature is here, users "just" need to use podOverrides to set these annotations. I would like to document the actual podOverrides as less as possible, as volume names are not guaranteed to be stable and the snippet in Trino can break any time. I would much rather implement it properly via a dedicated CRD field |
We don't document the name of the volume that needs to be overridden for each service, and the names differ between services. The documentation link you included is the graceful shutdown documentation for Trino, which doesn't feel like an intuitive place for this to live. |
Yep, that's a problem, combined with the volume name not being part of our public API (IMHO).
I would say definitively! I want a field such as |
I'm happy for this feature request to pivot from documentation to implementation of the fix proposed by @sbernauer |
WDYT @lfrancke? Should we park this ticket and wait for the proper implementation or start with the implementation right ahead? Or something else? |
I like the idea of the CRD field. |
I would say size M for all operators. First step is to come up with a CRD change. If it's a clusterConfig entry (e.g. |
@lfrancke this ticket is currently in refinement. if we instead now propose to change the course of action to instead implement something new, can we move this ticket somewhere else? Refinement seems done, and the outcome is to instead not do what is described here, but rather do something else (when?) |
We were just waiting for a decision on how to proceed here. I'd suggest a new issue for this. I can create one and will handle the movement of issues :) |
There is now a new overarching issue: stackabletech/issues#586 |
The docs state that the certificates provided by autoTLS can be configured to have a lifetime longer than the default (24 hours), but they are not clear as to how this is implemented. The docs could be improved by describing how this is done, ideally with an example to illustrate what the configuration should look like.
The text was updated successfully, but these errors were encountered: