From f135caec6b2fe8b55918fb55976c399a899df20b Mon Sep 17 00:00:00 2001 From: xeniape Date: Mon, 27 Jan 2025 14:35:50 +0100 Subject: [PATCH 1/2] chore: deprecate stackable_operator::logging::initialize_logging() --- crates/stackable-operator/CHANGELOG.md | 4 ++++ crates/stackable-operator/src/logging/mod.rs | 2 ++ 2 files changed, 6 insertions(+) diff --git a/crates/stackable-operator/CHANGELOG.md b/crates/stackable-operator/CHANGELOG.md index d3869aa15..0f53eb058 100644 --- a/crates/stackable-operator/CHANGELOG.md +++ b/crates/stackable-operator/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. ## [Unreleased] +### Changed + +- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead. + ## [0.84.1] - 2025-01-22 ### Fixed diff --git a/crates/stackable-operator/src/logging/mod.rs b/crates/stackable-operator/src/logging/mod.rs index 861edfa51..71a14045a 100644 --- a/crates/stackable-operator/src/logging/mod.rs +++ b/crates/stackable-operator/src/logging/mod.rs @@ -28,6 +28,7 @@ impl Default for TracingTarget { /// /// Log output can be copied to a file by setting `{env}_DIRECTORY` (e.g. `FOOBAR_OPERATOR_DIRECTORY`) /// to a directory path. This file will be rotated regularly. +#[deprecated(note = "Use stackable-telemetry instead, use OTLP instead of Jaeger protocol")] pub fn initialize_logging(env: &str, app_name: &str, tracing_target: TracingTarget) { let filter = match EnvFilter::try_from_env(env) { Ok(env_filter) => env_filter, @@ -94,6 +95,7 @@ mod tests { // NOT_SET=debug cargo test default_tracing -- --nocapture // to see them all. #[test] + #[allow(deprecated)] fn default_tracing_level_is_set_to_info() { super::initialize_logging("NOT_SET", "test", TracingTarget::None); From 2c551ee83c47b31b80377eaa2f84ef2f939587c7 Mon Sep 17 00:00:00 2001 From: xeniape Date: Mon, 27 Jan 2025 14:39:13 +0100 Subject: [PATCH 2/2] adjust changelog --- crates/stackable-operator/CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/stackable-operator/CHANGELOG.md b/crates/stackable-operator/CHANGELOG.md index 0f53eb058..43ffc5324 100644 --- a/crates/stackable-operator/CHANGELOG.md +++ b/crates/stackable-operator/CHANGELOG.md @@ -6,7 +6,9 @@ All notable changes to this project will be documented in this file. ### Changed -- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead. +- Deprecate `stackable_operator::logging::initialize_logging()`. It's recommended to use `stackable-telemetry` instead ([#950]). + +[#950]: https://github.com/stackabletech/operator-rs/pull/950 ## [0.84.1] - 2025-01-22