Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined role overrides are ignored by compute_files() #339

Open
razvan opened this issue Mar 4, 2022 · 0 comments
Open

User defined role overrides are ignored by compute_files() #339

razvan opened this issue Mar 4, 2022 · 0 comments

Comments

@razvan
Copy link
Member

razvan commented Mar 4, 2022

Description

Given a fictional CRD with role level configuration overrides like this:

brokers:
  configOverrides:
    server.properties:
      auto.create.topics.enable: "false"
  roleGroups:
    default:
      replicas: 1

and an implementation of Configuration::compute_files() that sets auto.create.topics.enable to true,
then the user defined override is ignored and the value of the property will be true.

Note that this doesn't happen with configuration overrides at group level!

The expectation of overrides is, that whatever the user has set , wins over everything else.

A test that demonstrates the bug is here: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants