Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label_selector::convert_label_selector_to_query_string && pod_utils::pod_matches_multiple_label_values should return all Errors in a list instead of one-by-one #127

Open
lfrancke opened this issue May 28, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@lfrancke
Copy link
Member

lfrancke commented May 28, 2021

Currently convert_label_selector_to_query_string will check the passed LabelSelector and as soon as it hits any error it will return that error.
There might be more than one error in the LabelSelector though.

We'd like to change the Error (InvalidLabelSelector) to contain a list of strings instead of a single string and return all errors in one go.

An example of how this could be handled can be found in the Zookeeper Operator:
https://github.com/stackabletech/zookeeper-operator/blob/ffd0d3d5fc47d0f9878f3675eeaae741ca09483b/crd/src/util.rs#L164

@lfrancke lfrancke changed the title label_selector::convert_label_selector_to_query_string should return all Errors in a list instead of one-by-one label_selector::convert_label_selector_to_query_string && pod_utils::pod_matches_multiple_label_values should return all Errors in a list instead of one-by-one Jun 9, 2021
@lfrancke
Copy link
Member Author

@teozkr I assume this is not relevant for us anymore, the whole module might have been removed?

If my assumption is correct: Could you close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant