Skip to content

Commit 8fcf506

Browse files
authoredSep 24, 2024··
fix: Logback configuration (#874)
1 parent 34c6c4f commit 8fcf506

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed
 

‎crates/stackable-operator/CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Fixed
8+
9+
- Fix the logback configuration for logback versions from 1.3.6/1.4.6 to
10+
1.3.11/1.4.11 ([#874]).
11+
12+
[#874]: https://github.com/stackabletech/operator-rs/pull/874
13+
714
## [0.76.0] - 2024-09-19
815

916
### Added

‎crates/stackable-operator/src/product_logging/framework.rs

+13-1
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,19 @@ pub fn create_logback_config(
589589
</rollingPolicy>
590590
<triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
591591
<MaxFileSize>{max_log_file_size_in_mib}MB</MaxFileSize>
592-
<checkIncrement>5 seconds</checkIncrement>
592+
<!--
593+
checkIncrement defines how often file sizes are checked, because
594+
checking them is a relatively costly operation.
595+
checkIncrement was introduced in the SizeBasedTriggeringPolicy in
596+
logback 1.3.6/1.4.6 as an Integer representing milliseconds. In logback
597+
1.3.12/1.4.12, it was changed to a Duration, also accepting a unit.
598+
Without a given unit, milliseconds are assumed. The logback manual is
599+
misleading: In logback 1.5.8, checkIncrement is no longer used for the
600+
SizeAndTimeBasedFileNamingAndTriggeringPolicy, but it is still used for
601+
the SizeBasedTriggeringPolicy!
602+
In prior versions of logback, setting this option has no effect.
603+
-->
604+
<checkIncrement>5000</checkIncrement>
593605
</triggeringPolicy>
594606
</appender>
595607

0 commit comments

Comments
 (0)
Please sign in to comment.