Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pinocchio.pc (pkg-config) #2525

Open
jorisv opened this issue Dec 20, 2024 · 3 comments
Open

Simplify pinocchio.pc (pkg-config) #2525

jorisv opened this issue Dec 20, 2024 · 3 comments

Comments

@jorisv
Copy link
Contributor

jorisv commented Dec 20, 2024

Pinocchio pkg-config file have a lot of drawback:

  • It doesn't allow to choose a particular pinocchio target
  • Code to generate it is redundant with the cmake target definition
  • Some dependencies like hpp-fcl doesn't provide .pc file anymore
  • jrl-cmakemodules code to manage .pc file generation is not maintained

I plan to simplify it by only allowing to link against pinocchio_default.

I don't know what pkg-config use case is. So if you use it, please, comment on this issue to expose your use case.

@nim65s
Copy link
Contributor

nim65s commented Dec 20, 2024

Also, boost does not provide a .pc, so our .pc are doomed to be incomplete, unless we generate the required boost.pc ourself.

I would advocate for a simple removal of pkg-config support from all our codebases, if nobody provide a convincing use case 👼🏼

@ManifoldFR
Copy link
Member

ManifoldFR commented Dec 20, 2024

I know there's been discussions about getting rid of pkg-config support - I also support it (to keep things simple and maintainable)

@jcarpent
Copy link
Contributor

On my side, I've just use pkg-config for quick compilation via g++:

g++ -O3 -std=c++14 -g overview-urdf.cpp -o overview-urdf $(pkg-config --cflags pinocchio) $(pkg-config --libs pinocchio) && ./overview-urdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants