From 23a638ebfb180aa7d4ea75f17e3d89477dcb6509 Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Fri, 3 Jan 2025 12:02:06 +0100 Subject: [PATCH 1/2] core: Fix aba explicit template instantiation core: Fix typo --- include/pinocchio/algorithm/aba.txx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/pinocchio/algorithm/aba.txx b/include/pinocchio/algorithm/aba.txx index 848a8ffd4e..3152c99cdd 100644 --- a/include/pinocchio/algorithm/aba.txx +++ b/include/pinocchio/algorithm/aba.txx @@ -7,7 +7,7 @@ namespace pinocchio { - extern template PINOCCHIO_EXPLICIT_INSTANTIATION_DEFINITION_DLLAPI const context::VectorXs & aba< + extern template PINOCCHIO_EXPLICIT_INSTANTIATION_DECLARATION_DLLAPI const context::VectorXs & aba< context::Scalar, context::Options, JointCollectionDefaultTpl, @@ -21,7 +21,7 @@ namespace pinocchio const Eigen::MatrixBase> &, const Convention); - extern template PINOCCHIO_EXPLICIT_INSTANTIATION_DEFINITION_DLLAPI const context::VectorXs & aba< + extern template PINOCCHIO_EXPLICIT_INSTANTIATION_DECLARATION_DLLAPI const context::VectorXs & aba< context::Scalar, context::Options, JointCollectionDefaultTpl, From a5bc9d0c5cc7d7ab15550562df7c773baedb10a0 Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Fri, 3 Jan 2025 12:03:51 +0100 Subject: [PATCH 2/2] changelog: Add entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 34569aafc6..d14d68601f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ### Fixed - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option ([#2526](https://github.com/stack-of-tasks/pinocchio/pull/2526)) +- Fix aba explicit template instantiation ([#2541](https://github.com/stack-of-tasks/pinocchio/pull/2541)) ## [3.3.1] - 2024-12-13