-
Notifications
You must be signed in to change notification settings - Fork 44
Loosen dependencies requirements #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Zaczero - thanks for opening the issue. I appreciate the challenges that the strict dependency requirements might impose on using Feel free to open a pull request with the changes you described! It might be fine to open everything up with |
Also remove unused packages: flake8, types-setuptools
The problem with >= is that you run into the strong possibility that you can get a breaking change in one of your dependencies. |
I am also struggling with integration because of the strict dependency versions. Although I do understand @bitner's point. I do see another PR opened in December also tried to loosen some dependencies: #331. Are you more comfortable with that method that limits it to anything prior to the next major release? |
Strictly pinning minor versions (like The Python ecosystem works best when packages specify reasonable version ranges (like Please look around the Python ecosystem, including well-established projects, and see that strict version pinning is an exception from how it's typically done. Your argument for strict pinning might make sense, but it goes against established practices in the Python ecosystem and creates real problems for users trying to integrate multiple packages together. |
I suggest as a compromise |
https://github.com/stac-utils/pgstac/blob/main/src/pypgstac/pyproject.toml
Such pinning makes it impossible to integrate this tool into other projects (without hacky workarounds like override-dependencies, forceful dependency overrides). And I assume the intention is to allow such use cases given the existence of py.typed file which otherwise would be redundant.
There exist online resources on this topic: https://discuss.python.org/t/should-i-be-pinning-my-dependencies/13159
A popular and good practice is to use
>=
for defining your dependencies.The text was updated successfully, but these errors were encountered: