You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I'm working on a fork of OSR that adds a "reshuffle" button. I don't have any expectations that my fork will be merged into the plugin, but I'd like to keep my fork to a high enough standard that it could be merged :)
When I attempt a git commit, I get the following error:
I suspect this test is failing due to a package / version problem, or some machine-specific date issue...
But before I try to debug and fix it, I'd like to first git commit --no-verify, and then fix this in a later commit. Is this acceptable, or should all commits pass all tests? This was not covered in CONTRIBUTING.md, hence my question :)
TLDR: When contributing, is it okay to git commit -n to bypass failing tests, then fix the problem in a later commit?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi, I'm working on a fork of OSR that adds a "reshuffle" button. I don't have any expectations that my fork will be merged into the plugin, but I'd like to keep my fork to a high enough standard that it could be merged :)
When I attempt a
git commit
, I get the following error:I suspect this test is failing due to a package / version problem, or some machine-specific date issue...
But before I try to debug and fix it, I'd like to first
git commit --no-verify
, and then fix this in a later commit. Is this acceptable, or should all commits pass all tests? This was not covered in CONTRIBUTING.md, hence my question :)TLDR: When contributing, is it okay to
git commit -n
to bypass failing tests, then fix the problem in a later commit?Beta Was this translation helpful? Give feedback.
All reactions