Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add shimmer in class view #9

Open
Diwakar-Gupta opened this issue Dec 9, 2023 · 1 comment
Open

Enhancement: Add shimmer in class view #9

Diwakar-Gupta opened this issue Dec 9, 2023 · 1 comment
Assignees
@Rudrakc
Labels
good first issue Good for newcomers in progress This issue is being worked on

Comments

@Diwakar-Gupta
Copy link
Collaborator

Diwakar-Gupta commented Dec 9, 2023 •
edited
Loading

In CurrentClassScreen.tsx where class is still not loaded if passes null to ClassView and ClassView has to handle null case but this should not handle ideally we should show a shimmer(placeholder) when CurrentClassScreen is fetching class data from server if there is a class then pass it to ClassView else show there is not class at all.
@Diwakar-Gupta Diwakar-Gupta changed the title Enhancement: Add schimmer in class view Enhancement: Add shimmer in class view Dec 9, 2023
@Rudrakc
Copy link

Rudrakc commented Dec 10, 2023 •
edited
Loading

I would like to work on this issue , please assign me

@Diwakar-Gupta Diwakar-Gupta added the good first issue Good for newcomers label Dec 14, 2023
@skushagra skushagra added the in progress This issue is being worked on label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rudrakc Rudrakc

Labels
good first issue Good for newcomers in progress This issue is being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Diwakar-Gupta @skushagra @Rudrakc