Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmax on algebraic should be larger than 1 #394

Open
gerritholl opened this issue Nov 10, 2023 · 3 comments
Open

vmax on algebraic should be larger than 1 #394

gerritholl opened this issue Nov 10, 2023 · 3 comments
Labels
component: ui enhancement New feature or request EUM-WIP This issue is (scheduled to) being worked on by EUM

Comments

@gerritholl
Copy link

gerritholl commented Nov 10, 2023

I defined an algebraic as the ratio between two channels (0.91 µm and 0.85 µm). In the layer details, I visualise this algebraic with the colormap "grays", and want to choose the range between 0.5 and 1.1. However, there is a hard limit on vmax set to 1, so it is not possible to set the upper limit to 1.1.

For a user-defined algebraic, there should not be any upper or lower limit to the colormap scale. Or if there has to be, the range could be set to something a bit more than the maximum value occurring in the dataset.

image

Interestingly, if I click "fit to data" I can get the upper limit to be (much) larger than 1.

(I thought I had seen this reported or perhaps even reported it myself; however, I can't find a related issue)

@djhoese
Copy link
Member

djhoese commented Nov 10, 2023

What were the initial vmaxes of the input bands to your algebraic. In old versions of SIFT I think the min/max was computed by running the inputs vmin/vmax into the code of your algebraic layer and taking the min/max of the results. I'm surprised by what you're seeing.

Otherwise, as a workaround, can you change the test of the slider to 1.1 and hit the Tab key (to go to another cell in the UI) and does it reflect that forced limit value?

@gerritholl
Copy link
Author

The input bands both have the range [-0.01, 1.19].

The UI does not let me manually write a number larger than 1.00. When I select my cursor there and type a larger number, the number does not appear.

As a workaround, when I select "Fit to data", the range jumps to [0.13, 3.39], and then it does let me change the upper limit to any value smaller than or equal to 3.39.

@ameraner ameraner added enhancement New feature or request component: ui EUM-WIP This issue is (scheduled to) being worked on by EUM labels May 6, 2024
@ameraner
Copy link
Collaborator

ameraner commented May 7, 2024

Adding the discussion from EUM Gitlab issue 120:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui enhancement New feature or request EUM-WIP This issue is (scheduled to) being worked on by EUM
Projects
None yet
Development

No branches or pull requests

3 participants