Skip to content

Clear the stale ISSUES.md register: S4, S5 and S8 #11

Description

@ssandys

ISSUES.md is the register a reviewer reads first, and three entries are stale or unresolved in ways that are cheap to close.

S4 — an unreproducible figure in AGENTS.md. "195 alerts filter down to 7" does not reproduce. Measured at the fixture's own header timestamp (1787689797): 9 active, of which 1 is amber or red. The surrounding figures were corrected and this one was left. Restate it or drop it.

S5 — a false justification comment in scripts/build-stations.mjs. The comment says "a terminal has no label for the direction it does not serve." Measured: 0 of 496 rows have an empty labelN or labelS — a terminal carries the literal string "Last Stop", which is exactly what Stations.directionsFor filters on. The tolerant branch is harmless; its stated reason is wrong.

S8 — a real, currently unreachable NaN. Stations.search still yields NaN on a non-finite station coordinate; the earlier fix guarded the origin only. A row with a bad lat sorts first with distanceKm: NaN. 0 of 496 committed rows are non-finite and build-stations.mjs now throws on a non-finite gtfs_latitude/gtfs_longitude, so it cannot be generated today — but the guard is one comparison and would make the property hold by construction rather than by upstream accident.

Why now: S7 sat in this file marked open for a week after it had already been fixed, and was only caught by reading the code during the marketplace review. The register drifts without an occasional sweep, and it is the first thing an outside reviewer reads.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions