Skip to content

package.json is at 0.1.0 while manifest.json is at 0.1.2, and no test guards it #10

Description

@ssandys

package.json declares "version": "0.1.0". manifest.json declares "version": "0.1.2".

manifest.json is the one that matters — it is what the marketplace reads and what the validation bot reports. package.json describes itself as "Build and test harness only", so the drift is cosmetic today. But it is drift, it happened silently across two releases, and tests/manifest.test.js already guards four other consistency properties:

  • the manifest declares the plugin id the docs promise
  • every schema key has a matching default
  • Service.qml's setting() fallbacks match the manifest defaults
  • the devkit scripts carry no plugin-specific literal

A fifth assertion — that the two version strings agree — is one line, and fits the file's existing purpose exactly. Either that, or drop the version field from package.json so there is only one source of truth.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions