Skip to content

Offer to reload after applying num_ctx to a loaded model #8

Description

@ssandys

Applying a num_ctx change to a model that is currently loaded does nothing visible: num_ctx is allocated when the model loads, so the running instance keeps the window it was loaded with. Today the only thing that says so is a Known-limitations paragraph in README.md.

Raised by @dchristensen8 on #6 ("it's not a live change on a running model"), and correct.

Proposal. When apply succeeds for a model that appears in snap.loaded, offer the reload inline — an "unload to apply" affordance on the apply row. Everything needed is already present: Service.qml holds the loaded set, and the unload verb is already wired for the button.

Why it is worth doing. This is the one place where the feature silently appears not to work. The user did the right thing, got a success, and sees no change.

Acceptance. Applying to a loaded model surfaces the reload path; applying to an unloaded one does not. The README limitation shrinks to a note rather than a warning.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions