Overall, this repo looks great. Some feedback to consider in future:
-
Define access level for variables declared in a class. For instance Context context;, List<User> users;, and TwitterClient client; in UserAdapter.Java in a1fa112
-
Add some explanatory comments and/or function docs when you feel necessary. For example, can add some comments in the long onCreate function a1fa112. An good example is 2ca3710
-
Think about and handle edge cases if possible. For example, the getApiUrl in TwitterClient.java returns the null string. 5e73839
Overall, this repo looks great. Some feedback to consider in future:
Define access level for variables declared in a class. For instance
Context context;,List<User> users;, andTwitterClient client;inUserAdapter.Javain a1fa112Add some explanatory comments and/or function docs when you feel necessary. For example, can add some comments in the long onCreate function a1fa112. An good example is 2ca3710
Think about and handle edge cases if possible. For example, the getApiUrl in TwitterClient.java returns the null string. 5e73839