Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant loading: returning to index page breaks search and other features #6275

Closed
4 tasks done
sarcastro opened this issue Nov 1, 2023 · 9 comments
Closed
4 tasks done
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@sarcastro
Copy link

Context

No response

Bug description

Search is not functional from the index page when navigation.instant is enabled except for when first loaded.

Refreshing page restores functionality.

Note: issue does not appear to be limited to search as page no longer refreshes automatically when using mkdocs serve either.

Related links

Reproduction

9.4.7-navigation-instant-index.zip

Steps to reproduce

  1. Navigate away from index page (e.g. by following a link)
  2. Return to index page (e.g. using left navigation menu)
  3. Try to search (no longer functional)

Note: steps to reproduce are included in the reproduction as well.

Browser

No response

Before submitting

@sarcastro sarcastro changed the title Navigation: navigation.instant breaks search and other features when returning to inst Navigation: navigation.instant breaks search and other features when returning to index page Nov 1, 2023
@squidfunk squidfunk added the bug Issue reports a bug label Nov 2, 2023
@squidfunk
Copy link
Owner

squidfunk commented Nov 2, 2023

Thanks for reporting! I think this should be fixed with 494cae1!

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Nov 2, 2023
@sarcastro
Copy link
Author

sarcastro commented Nov 3, 2023

Thanks for reporting! I think this should be fixed with 494cae1!

Fantastic, much appreciated! I'll let you know the verdict

@squidfunk
Copy link
Owner

Released as part of 9.4.8.

@sarcastro
Copy link
Author

Released as part of 9.4.8.

Didn't seem to make a difference, unfortunately. Here's a new reproduction with the same configuration and steps to reproduce as before.

9.4.8-navigation-instant-index-2.zip

@sarcastro
Copy link
Author

@squidfunk - should I create a duplicate report?

@squidfunk
Copy link
Owner

squidfunk commented Nov 29, 2023

No, I'll look into it once I find some time. Sorry, I've had this in my inbox but I'm currently busy with #6307.

@squidfunk squidfunk reopened this Nov 29, 2023
@squidfunk squidfunk added needs investigation Issue must be investigated by the maintainers and removed bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Nov 29, 2023
@squidfunk squidfunk added bug Issue reports a bug and removed needs investigation Issue must be investigated by the maintainers labels Dec 11, 2023
@squidfunk squidfunk changed the title Navigation: navigation.instant breaks search and other features when returning to index page Instant loading: returning to index page breaks search and other features Dec 11, 2023
@squidfunk
Copy link
Owner

Fixed in https://github.com/squidfunk/mkdocs-material-insiders/pull/79 – the fixes are currently only in Insiders, so anybody having access can already test them. I still need to do some minor refactoring that shouldn't impact the functionality, and after that, I'll backport the fixes to the community edition. I just wanted to give them into the hands of users as soon as possible. This should resolve all known problems with instant loading, at least I've tested this and all other issues.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jan 18, 2024
@squidfunk
Copy link
Owner

Fixes are now in #6662. Please check if the errors are now fixed when using this version in your project:

pip install git+https://github.com/squidfunk/mkdocs-material.git@fix/instant-loading-bugs

@squidfunk
Copy link
Owner

Released as part of 9.5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants