Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] big_number component - Add support for link to open other links #859

Open
accforgithubtest opened this issue Mar 17, 2025 · 1 comment · May be fixed by #861
Open

[feat] big_number component - Add support for link to open other links #859

accforgithubtest opened this issue Mar 17, 2025 · 1 comment · May be fixed by #861
Labels
enhancement New feature or request

Comments

@accforgithubtest
Copy link

It would be great if the big_number component can support row level parameters for link and target, that would allow the big_number item to be clickable and open another link (in a new tab if a _blank is specified for target, else in same window).

It would be useful in cases where a "Total" is highlighted using a big_number component, and clicking on the big number will open another .sql page which provides more detailed information, etc.

I see that there is a dropdown_item, which seems fine for the usecase highlighted in example to provide options to change preset date range, however when I use it for the redirect link, it does not feel right.

A directly clickable big_number component would be more user friendly.

@accforgithubtest accforgithubtest added the enhancement New feature or request label Mar 17, 2025
@lovasoa
Copy link
Collaborator

lovasoa commented Mar 18, 2025

Yes, that would be nice indeed ! Pull request welcome ! The source is here https://github.com/sqlpage/SQLPage/blob/main/sqlpage/templates/big_number.handlebars

target=_blank is not very intuitive for people who are not already familiar with html, maybe we can find a better name for the option.

@lovasoa lovasoa linked a pull request Mar 19, 2025 that will close this issue
@lovasoa lovasoa linked a pull request Mar 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants