Refactor setup-cross-compilation.sh for improved readability

lovasoa · lovasoa · commit 9c79bc0ad4b4 · 2025-11-20T00:23:07.000+01:00
- Changed the syntax for checking BINDGEN_EXTRA_CLANG_ARGS to use a conditional statement for clarity.
- This enhances the script's maintainability while preserving its functionality.
diff --git a/scripts/setup-cross-compilation.sh b/scripts/setup-cross-compilation.sh
@@ -37,5 +37,7 @@ rustup target add "$TARGET"
 {
     echo "export TARGET='$TARGET'"
     echo "export LINKER='$LINKER'"
-    [ -n "$BINDGEN_EXTRA_CLANG_ARGS" ] && printf "export BINDGEN_EXTRA_CLANG_ARGS=%q\n" "$BINDGEN_EXTRA_CLANG_ARGS"
+    if [ -n "$BINDGEN_EXTRA_CLANG_ARGS" ]; then
+        printf "export BINDGEN_EXTRA_CLANG_ARGS=%q\n" "$BINDGEN_EXTRA_CLANG_ARGS"
+    fi
 } > /tmp/build-env.sh

Original file line number	Diff line number	Diff line change
`@@ -37,5 +37,7 @@ rustup target add "$TARGET"`
`37`	`37`	`{`
`38`	`38`	`echo "export TARGET='$TARGET'"`
`39`	`39`	`echo "export LINKER='$LINKER'"`
`40`		`- [ -n "$BINDGEN_EXTRA_CLANG_ARGS" ] && printf "export BINDGEN_EXTRA_CLANG_ARGS=%q\n" "$BINDGEN_EXTRA_CLANG_ARGS"`
	`40`	`+ if [ -n "$BINDGEN_EXTRA_CLANG_ARGS" ]; then`
	`41`	`+ printf "export BINDGEN_EXTRA_CLANG_ARGS=%q\n" "$BINDGEN_EXTRA_CLANG_ARGS"`
	`42`	`+ fi`
`41`	`43`	`} > /tmp/build-env.sh`