-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting on save throws error but still appears to work(?) #63
Comments
@dschneiderch Do you have any extension specific settings? I'm not quite sure why it wouldn't be picking up your config file, but sometimes the easiest solution is just to manually set the config setting specifically for your workspace. |
These are my extension specific settings
i added these and now it gets the config file at least. can there be multiple config locations? i'm wondering how to handle nested sql files
I still see this error in the log but it happens with i used the integrated terminal too. i guess this might be a sqlfluff issue?:
|
Looking at that last error, that is coming from a different file that i'm not trying to lint. And that file used to work fine once I added |
Using the "sqlfluff.config": "${workspaceFolder}/path/to/sqlfluff" But if you want to use multiple configuration files you could try something like this, which is basically telling the extension to run the commands from the file directory. Basically what would happen if you cd into that directory and run the sqlfluff command. If you try this you should comment out or remove the config setting. "sqlfluff.workingDirectory": "${fileDirname}" As for that last error, it looks like a sqlfluff or setup issue so not something I could fix with this extension. |
when i added the workingDirectory entry and removed the config entry it
|
Hm ok, probably best not to use that setting for now then. Are you able to get everything working just using the config setting? Or do you need to use multiple .sqlfluff configuration files at once? |
In that repo I was testing on its just a flat hierarchy (for now). In newer repos we've organized into a nested structure though. And in one folder
|
I don't think its recognizing my .sqlfluff config file since its complaining about the dialect but then linting shows up anyway. the config is at /Users/dschneider/bombora/repos/topic-interest-score-af2-dags/bombora/bairflow/topic_interest_score/include/sql
my config:
the error:
The text was updated successfully, but these errors were encountered: