Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QTextCodec #98

Open
jitseniesen opened this issue Jan 29, 2025 · 0 comments · May be fixed by #99
Open

Remove QTextCodec #98

jitseniesen opened this issue Jan 29, 2025 · 0 comments · May be fixed by #99
Assignees
@jitseniesen
Labels
type:task
Milestone
v0.4.1

Comments

@jitseniesen
Copy link
Member

The plugin uses QTextCodec to read the output of the profiler process. According to spyder-ide/spyder#20201, this blocks supporting Qt6, so we need to remove it. The PR spyder-ide/spyder#9652 may show how.
@jitseniesen jitseniesen added this to the v0.4.1 milestone Jan 29, 2025
@jitseniesen jitseniesen self-assigned this Jan 29, 2025
rear1019 added a commit to procitec/spyder-line-profiler that referenced this issue Feb 19, 2025
@rear1019
Remove usage of QTextCodec and fix encoding
4c438b0 
- QTextCodec has been removed in Qt 6. Remove its usage to make code
  compatible with Qt 6.

- Also use correct encoding when decoding data from Python process

This fixes issue spyder-ide#98.
@rear1019 rear1019 linked a pull request Feb 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jitseniesen jitseniesen

Labels
type:task
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging a pull request may close this issue.

Remove usage of QTextCodec and fix encoding procitec/spyder-line-profiler
1 participant
@jitseniesen