Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wireformat] Use signatures instead of qualified names when possible #104

Open
toth-istvan-zoltan opened this issue Feb 1, 2025 · 0 comments

Comments

@toth-istvan-zoltan
Copy link
Contributor

As of now:

  • wire formats contain fully qualified class names for polymorphic formats even when the data is primitive
  • WireFormatRegistry also uses fully qualified names for primitive types
object WireFormatRegistry : Registry<WireFormat<*>>() {
    init {
        val n = WireFormatTypeArgument<Any>(PolymorphicWireFormat, true)
        
        set("kotlin.Any", PolymorphicWireFormat)

        set("kotlin.Byte", ByteWireFormat)
        set("kotlin.Short", ShortWireFormat)
        set("kotlin.Int", IntWireFormat)

This feels like a waste when we actually have short signatures already.

Investigate if the conversion of these long names into signatures is feasible.

@toth-istvan-zoltan toth-istvan-zoltan changed the title Use signatures instead of qualified names when possible [wireformat] Use signatures instead of qualified names when possible Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant