Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use JDK xml utilities instead of simple-xml? #1

Open
jvanzyl opened this issue May 16, 2016 · 4 comments
Open

Possible to use JDK xml utilities instead of simple-xml? #1

jvanzyl opened this issue May 16, 2016 · 4 comments

Comments

@jvanzyl
Copy link

jvanzyl commented May 16, 2016

I am using xar in a utilities where I'm making a shaded JAR, and the simple-xml framework is doubling the size. Not a huge concern but seems everything required to parse the simple ToC is in the JDK.

@rzimmer
Copy link
Contributor

rzimmer commented May 17, 2016

Thanks for your feedback and great to hear that you're using our project! You're right, the current dependency to simple-xml is a bit heavy. After we kicked out Guava (which was obviously even more a concern!), we'll definitely take replacing simple-xml with something lightweight in consideration. The JDK or a thin wrapper around it sounds good, we still need to look into Android compatibility, though. Give us some time, please 😄

@jvanzyl
Copy link
Author

jvanzyl commented Jun 2, 2016

I have forked your repo and released to central so that I can release this:

https://github.com/takari/jdkget

Thanks for the XAR code, very helpful!

@rzimmer
Copy link
Contributor

rzimmer commented Jun 2, 2016

Great, thanks for releasing! I've just created #2 to track progress for when we have implemented the "official" deployment to central. Unfortunately, time is short these busy days...

@jvanzyl
Copy link
Author

jvanzyl commented Jun 2, 2016

No problem. No rush on my side. I'm good for now.

rzimmer pushed a commit that referenced this issue Sep 7, 2016
They can't be used on Android anyway and it reduces the (shaded) standalone version in size (#1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants