Skip to content

Fix network settings to turn off if setting is off (and dont exit if its enabled and already running) #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisj951 merged 1 commit into from
Feb 4, 2026
Merged

Fix network settings to turn off if setting is off (and dont exit if its enabled and already running) #1212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions spruce/scripts/networkservices.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,33 +24,43 @@ connect_services() {
done

# Samba check
if [ "$samba_enabled" = "True" ] && ! pgrep "smbd" >/dev/null; then
# Flag exists but service is not running, so start it...
log_message "Network services: Samba detected not running, starting..."
start_samba_process
if [ "$samba_enabled" = "True" ]; then
if ! pgrep "smbd" >/dev/null; then
log_message "Network services: Samba detected not running, starting..."
start_samba_process
fi
else
stop_samba_process
fi

# SSH check
if [ "$ssh_enabled" = "True" ] && ! pgrep "$SSH_SERVICE_NAME" >/dev/null; then
# Flag exists but service is not running, so start it...
log_message "Network services: $SSH_SERVICE_NAME detected not running, starting..."
start_ssh_process
if [ "$ssh_enabled" = "True" ]; then
if ! pgrep "$SSH_SERVICE_NAME" >/dev/null; then
log_message "Network services: $SSH_SERVICE_NAME detected not running, starting..."
start_ssh_process
fi
else
stop_ssh_process
fi

# SFTPGo check
if [ "$sftpgo_enabled" = "True" ] && ! pgrep "$SFTP_SERVICE_NAME" >/dev/null; then
# Flag exists but service is not running, so start it...
log_message "Network services: SFTPGo detected not running, starting..."
start_sftpgo_process
if [ "$sftpgo_enabled" = "True" ]; then
if ! pgrep "$SFTP_SERVICE_NAME" >/dev/null; then
log_message "Network services: SFTPGo detected not running, starting..."
start_sftpgo_process
fi
else
stop_sftpgo_process
fi

# Syncthing check
if [ "$syncthing_enabled" = "True" ] && ! pgrep "syncthing" >/dev/null; then
# Flag exists but service is not running, so start it...
log_message "Network services: Syncthing detected not running, starting..."
start_syncthing_process
if [ "$syncthing_enabled" = "True" ]; then
if ! pgrep "syncthing" >/dev/null; then
log_message "Network services: Syncthing detected not running, starting..."
start_syncthing_process
fi
else
stop_syncthing_process
fi

# Start Network Services Landing page
Expand Down