You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Defect where controlled components' props were overridden by React.Children.map (https://github.com/springload/react-accessible-accordion/issues/33).
20
-
- Defect where accordion crashed with unexpected `children` types (https://github.com/springload/react-accessible-accordion/issues/45).
21
-
- Defect where React Accessible Accordion's components could not be extended.
22
-
- Defect where the `children` of `Accordion` or `AccordionItem` could not be arbitrary.
23
-
- Defect where `AccordionItem` had to be a child of `Accordion` (as opposed to to an arbitrary-level descendant).
24
-
- Defect where `AccordionItemBody` and `AccordionItemTitle` had to be children of `AccordionItem` (as opposed to arbitrary-level descendants).
26
+
* Defect where controlled components' props were overridden by React.Children.map (https://github.com/springload/react-accessible-accordion/issues/33).
27
+
* Defect where accordion crashed with unexpected `children` types (https://github.com/springload/react-accessible-accordion/issues/45).
28
+
* Defect where React Accessible Accordion's components could not be extended.
29
+
* Defect where the `children` of `Accordion` or `AccordionItem` could not be arbitrary.
30
+
* Defect where `AccordionItem` had to be a child of `Accordion` (as opposed to to an arbitrary-level descendant).
31
+
* Defect where `AccordionItemBody` and `AccordionItemTitle` had to be children of `AccordionItem` (as opposed to arbitrary-level descendants).
25
32
26
33
### Removed:
27
34
28
-
- 🚨 Breaking change 🚨 `activeItems` property is no longer supported.
35
+
* 🚨 Breaking change 🚨 `activeItems` property is no longer supported.
29
36
30
37
Control at the `Accordion` level (via the `activeItems` prop) and `AccordionItem` level (via the `expanded` prop) fought against one another, and choosing which control mechanism to give preference to would have been an arbitrary decision - and whichever way we went, we would have had test cases which demonstrated unusual/unpredictable behaviour. The `activeItems` mechanism was the obvious one to remove - it was arguably the "less React-y way", and we considered it more of a convenience than a feature. Crucially though, it fought too hard against the new architecture of the library, and keeping it would have prevented us enabling lots of other new features or resolving some of the issues that our users had raised.
31
38
@@ -50,55 +57,54 @@ Please don't hesitate to reach out to one of the maintainers (or raise an issue)
0 commit comments