Skip to content

Commit 3ff1442

Browse files
committed
use explicit assertions in AccordionItemTitle tests instead of snapshots
1 parent e015635 commit 3ff1442

File tree

2 files changed

+28
-91
lines changed

2 files changed

+28
-91
lines changed
Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,5 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`AccordionItemTitle doesn't respect hideBodyClassName when collapsed 1`] = `
4-
<div
5-
aria-controls="accordion__body-item-two-uuid"
6-
aria-expanded={true}
7-
className="accordion__title"
8-
disabled={false}
9-
id="accordion__title-item-two-uuid"
10-
onClick={[Function]}
11-
onKeyPress={[Function]}
12-
role="button"
13-
tabIndex="0"
14-
>
15-
<div>
16-
Fake title
17-
</div>
18-
</div>
19-
`;
20-
21-
exports[`AccordionItemTitle renders correctly with different className 1`] = `
22-
<div
23-
aria-controls="accordion__body-item-one-uuid"
24-
aria-expanded={false}
25-
className="testCSSClass"
26-
disabled={false}
27-
id="accordion__title-item-one-uuid"
28-
onClick={[Function]}
29-
onKeyPress={[Function]}
30-
role="button"
31-
tabIndex="0"
32-
>
33-
<div>
34-
Fake Title
35-
</div>
36-
</div>
37-
`;
38-
393
exports[`AccordionItemTitle renders correctly with min params 1`] = `
404
<div
415
aria-controls="accordion__body-item-one-uuid"
@@ -53,21 +17,3 @@ exports[`AccordionItemTitle renders correctly with min params 1`] = `
5317
</div>
5418
</div>
5519
`;
56-
57-
exports[`AccordionItemTitle renders with different hideBodyClassName 1`] = `
58-
<div
59-
aria-controls="accordion__body-item-one-uuid"
60-
aria-expanded={false}
61-
className="accordion__title testCSSClass--hidden"
62-
disabled={false}
63-
id="accordion__title-item-one-uuid"
64-
onClick={[Function]}
65-
onKeyPress={[Function]}
66-
role="button"
67-
tabIndex="0"
68-
>
69-
<div>
70-
Fake title
71-
</div>
72-
</div>
73-
`;

src/AccordionItemTitle/accordion-item-title.spec.js

Lines changed: 28 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -46,48 +46,39 @@ describe('AccordionItemTitle', () => {
4646
});
4747

4848
it('renders correctly with different className', () => {
49-
const tree = renderer
50-
.create(
51-
<AccordionItemTitle
52-
className="testCSSClass"
53-
accordionStore={accordionStore}
54-
uuid="item-one-uuid"
55-
>
56-
<div>Fake Title</div>
57-
</AccordionItemTitle>,
58-
)
59-
.toJSON();
60-
expect(tree).toMatchSnapshot();
49+
const className = 'className';
50+
const wrapper = mount(
51+
<AccordionItemTitle
52+
className={className}
53+
accordionStore={accordionStore}
54+
uuid="item-one-uuid"
55+
/>,
56+
);
57+
expect(wrapper.find('div').hasClass(className)).toEqual(true);
6158
});
6259

6360
it('renders with different hideBodyClassName', () => {
64-
const tree = renderer
65-
.create(
66-
<AccordionItemTitle
67-
hideBodyClassName="testCSSClass--hidden"
68-
accordionStore={accordionStore}
69-
uuid="item-one-uuid"
70-
>
71-
<div>Fake title</div>
72-
</AccordionItemTitle>,
73-
)
74-
.toJSON();
75-
expect(tree).toMatchSnapshot();
61+
const hideBodyClassName = 'hideBodyClassName';
62+
const wrapper = mount(
63+
<AccordionItemTitle
64+
hideBodyClassName={hideBodyClassName}
65+
accordionStore={accordionStore}
66+
uuid="item-one-uuid"
67+
/>,
68+
);
69+
expect(wrapper.find('div').hasClass(hideBodyClassName)).toEqual(true);
7670
});
7771

78-
it("doesn't respect hideBodyClassName when collapsed", () => {
79-
const tree = renderer
80-
.create(
81-
<AccordionItemTitle
82-
hideBodyClassName="testCSSClass--hidden"
83-
accordionStore={accordionStore}
84-
uuid="item-two-uuid"
85-
>
86-
<div>Fake title</div>
87-
</AccordionItemTitle>,
88-
)
89-
.toJSON();
90-
expect(tree).toMatchSnapshot();
72+
it("doesn't present hideBodyClassName when collapsed", () => {
73+
const hideBodyClassName = 'hideBodyClassName';
74+
const wrapper = mount(
75+
<AccordionItemTitle
76+
hideBodyClassName={hideBodyClassName}
77+
accordionStore={accordionStore}
78+
uuid="item-two-uuid"
79+
/>,
80+
);
81+
expect(wrapper.find('div').hasClass(hideBodyClassName)).toEqual(false);
9182
});
9283

9384
it('renders correctly when pressing enter', async () => {

0 commit comments

Comments
 (0)