Migrate autoconfiguration to Spring Boot

[dsyer]

Should be mostly straightforward. Just a package change.

Things to watch out for:

• OAuth2 - autconfig classes were copied from Spring Boot, so there will be clashes and condition corner cases. It would be best if Spring Boot sorted its own approach out first - e.g. to make it easier to configure OAuth2 clients in a non-webapp. The biggest challenge for us will be gRPC embedded in a servlet or webflux app, and wanting to use OAuth2 as well (there should be some stuff that can be shared in the servlet case, but maybe not in webflux).
• Where to put the samples? There are probably too many for them all to be used as smoke tests in Spring Boot, but they are valuable integration tests. We could leave them here I guess (cyclic dependency), or move them to a new samples repo (like Spring Security).

[HyunSangHan]

Hi 👋
Can I take a look at this issue? :)

[HyunSangHan]

Oh, sorry. I should have checked there was already an assignee.

[onobc]

Hi @HyunSangHan ,

Thank you for reaching out. I am already about to start on this one and things can grow a bit out of hand when moving a project into Spring Boot (e.g. spring-pulsar). I know the spring-grpc issue list is down to a minimum (which is good and bad at the same time as it makes it difficult to find things to work on). We will discuss this at our next team meeting and see if we can find other candidate issues that may interest you.

Thanks,
Chris

[Sineaggi]

How will auto-configuration work with spring boot test?

As-is, if you want to test with @SpringBootTest, you'd set webEnvironment to your choice of mock, none or random_port. How would that interact with grpc? Will there be an equivalent grpcEnvironment, or will webEnvironment pull double-duty?

We have currently been using a combination of properties = ["spring.grpc.server.port=0"], and @LocalGrpcPort.

[dsyer]

if you want to test with @SpringBootTest

It shouldn’t be any different after the migration than it is now. If there’s something awkward about it please ask in a separate thread/issue. There are many examples in the project already.

[onobc]

This feature is in "ready for review" status.

• On the Spring gRPC side we have removed the modules from main
• On the Spring Boot side we have this PR

Once the Spring Boot PR is merged here are the remaining post-merge steps:

• figure out what docs to move / split between boot (leaving this alone for now on both sides boot and grpc)
• re-enable spring-grpc-docs
• re-enable samples
• move libs now managed by Boot from spring-grpc-build-dependencies to spring-grpc-dependencies

[dsyer]

LGTM. I assume the samples work locally if you build Spring Boot from the PR.