Skip to content

Consider implemented interfaces during @Import processing #34805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Apr 23, 2025 · 1 comment · May be fixed by #34820
Closed

Consider implemented interfaces during @Import processing #34805

wilkinsona opened this issue Apr 23, 2025 · 1 comment · May be fixed by #34820
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

See spring-projects/spring-boot#45252 for background.

ConfigurationClassParser does not consider implemented interfaces when finding @Import (meta-)annotations. It would enable the scenario described in spring-projects/spring-boot#45252 if it did. I think it would also be more consistent with other areas of Framework where implemented interfaces are considered. The test context framework is one such area.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 23, 2025
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 23, 2025
@jhoeller jhoeller added this to the 7.0.x milestone Apr 23, 2025
kwondh5217 added a commit to kwondh5217/spring-framework that referenced this issue Apr 24, 2025
@kwondh5217
Support @import on interfaces
f94b5bc 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <[email protected]>
kwondh5217 added a commit to kwondh5217/spring-framework that referenced this issue Apr 24, 2025
@kwondh5217
Support @import on interfaces
574c740 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <[email protected]>
@kwondh5217 kwondh5217 mentioned this issue Apr 24, 2025
Open
kwondh5217 added a commit to kwondh5217/spring-framework that referenced this issue Apr 24, 2025
@kwondh5217
Support @Import on interfaces
6ff1e2d 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <[email protected]>
@sbrannen
Copy link
Member

sbrannen commented Jun 3, 2025

Superseded by

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2025
@sbrannen sbrannen removed this from the 7.0.x milestone Jun 3, 2025
@sbrannen sbrannen added the status: superseded An issue that has been superseded by another label Jun 3, 2025
kwondh5217 added a commit to kwondh5217/spring-framework that referenced this issue Jun 3, 2025
@kwondh5217
Adjust @Import processing to prioritize local declarations
d48fb7f 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <[email protected]>
kwondh5217 added a commit to kwondh5217/spring-framework that referenced this issue Jun 3, 2025
@kwondh5217
Adjust @Import processing to prioritize local declarations
a3dd3d2 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support @Import on interfaces kwondh5217/spring-framework
4 participants
@sbrannen @wilkinsona @jhoeller @spring-projects-issues