Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jcstress for Concurrency related tests #2016

Open
mipo256 opened this issue Mar 14, 2025 · 1 comment
Open

Jcstress for Concurrency related tests #2016

mipo256 opened this issue Mar 14, 2025 · 1 comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged

Comments

@mipo256
Copy link
Contributor

mipo256 commented Mar 14, 2025

I was just debugging an issue in the concurrency-related integration tests in the JdbcRepositoryConcurrencyIntegrationTests, and the setup for concurrency is a bit clumsy, to put friendly. I think, we can introduce the jcstress JDK library for that.

What are your thoughts on this @schauder @mp911de? That would unify the way the concurrency tests are set up.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 14, 2025
@mp911de
Copy link
Member

mp911de commented Mar 19, 2025

Tests mentioned above provide a rather explicit way of guarding and latching. Someone not familiar with jcstress has a steep learning curve and that sort of tests expect a high throughput to catch bugs that are likely in high-concurrency scenarios. For the time being, I suggest not introducing yet another tool. If you feel, that JdbcRepositoryConcurrencyIntegrationTests can be optimized for readability, feel free to submit a PR so we can discuss whether we share the same understanding of better readability.

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants