Skip to content

Commit ac74d12

Browse files
Polishing.
Add issue reference and additional test for dot path resolution. Original Pull Request: #2650
1 parent 72d6101 commit ac74d12

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java

+12-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ void bindsDateCorrectly() throws ParseException {
199199
assertThat(predicate).isEqualTo(QUser.user.dateOfBirth.eq(format.parseDateTime(date).toDate()));
200200
}
201201

202-
@Test
202+
@Test // GH-2649
203203
void resolvesCommaSeparatedArgumentToListCorrectly() {
204204

205205
values.add("nickNames", "Walt,Heisenberg");
@@ -211,6 +211,17 @@ void resolvesCommaSeparatedArgumentToListCorrectly() {
211211
assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg"));
212212
}
213213

214+
@Test // GH-2649
215+
void resolvesCommaSeparatedArgumentToListCorrectlyForNestedPath() {
216+
217+
values.add("user.nickNames", "Walt,Heisenberg");
218+
219+
Predicate predicate = builder.getPredicate(ClassTypeInformation.from(UserWrapper.class), values, DEFAULT_BINDINGS);
220+
Constant<Object> constant = (Constant<Object>) ((List<?>) getField(getField(predicate, "mixin"), "args")).get(0);
221+
222+
assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg"));
223+
}
224+
214225
@Test // DATACMNS-883
215226
void automaticallyInsertsAnyStepInCollectionReference() {
216227

0 commit comments

Comments
 (0)