refactor: use type-safe constants in ExitStatus.isRunning

sjiwon · sjiwon · commit 1b3098a7a133 · 2025-03-15T16:37:45.000+09:00
Signed-off-by: sjiwon &lt;sjiwon4491@gmail.com&gt;
diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/ExitStatus.java b/spring-batch-core/src/main/java/org/springframework/batch/core/ExitStatus.java
@@ -28,6 +28,7 @@
  *
  * @author Dave Syer
  * @author Mahmoud Ben Hassine
+ * @author JiWon Seo
  *
  */
 public class ExitStatus implements Serializable, Comparable<ExitStatus> {
@@ -230,7 +231,7 @@ public ExitStatus replaceExitCode(String code) {
 	 * @return {@code true} if the exit code is {@code EXECUTING} or {@code UNKNOWN}.
 	 */
 	public boolean isRunning() {
-		return "EXECUTING".equals(this.exitCode) || "UNKNOWN".equals(this.exitCode);
+		return EXECUTING.exitCode.equals(this.exitCode) || UNKNOWN.exitCode.equals(this.exitCode);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`*`
`29`	`29`	`* @author Dave Syer`
`30`	`30`	`* @author Mahmoud Ben Hassine`
	`31`	`+ * @author JiWon Seo`
`31`	`32`	`*`
`32`	`33`	`*/`
`33`	`34`	`public class ExitStatus implements Serializable, Comparable<ExitStatus> {`
`@@ -230,7 +231,7 @@ public ExitStatus replaceExitCode(String code) {`
`230`	`231`	`* @return {@code true} if the exit code is {@code EXECUTING} or {@code UNKNOWN}.`
`231`	`232`	`*/`
`232`	`233`	`public boolean isRunning() {`
`233`		`- return "EXECUTING".equals(this.exitCode) \|\| "UNKNOWN".equals(this.exitCode);`
	`234`	`+ return EXECUTING.exitCode.equals(this.exitCode) \|\| UNKNOWN.exitCode.equals(this.exitCode);`
`234`	`235`	`}`
`235`	`236`
`236`	`237`	`/**`