refactor: improve ToolCallbackProvider injection using ObjectProvider #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct List<ToolCallbackProvider> injection with ObjectProvider pattern for better flexibility and backward compatibility in tool callback autoconfiguration. - Use ObjectProvider<List<ToolCallbackProvider>> and ObjectProvider<ToolCallbackProvider> for flexible bean resolution - Add merging and de-duplication logic for ToolCallbackProvider instances from multiple sources - Update StatelessToolCallbackConverterAutoConfiguration with new provider handling in syncTools() and asyncTools() methods - Update ToolCallbackConverterAutoConfiguration with similar provider handling improvements - Enhance ToolCallingAutoConfiguration toolCallbackResolver() to support both legacy List injection and new ObjectProvider pattern - Add test coverage Co-authored-by: Yanming Zhou <[email protected]> Signed-off-by: Christian Tzolov <[email protected]>
ilayaperumalg
approved these changes
Nov 12, 2025
Member
|
Rebased and merged as e4926e5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace direct List injection with ObjectProvider pattern for better flexibility and backward compatibility in tool callback autoconfiguration.