feat: enhance error handling in ChromaApi with detailed logging for not found exceptions

Signed-off-by: liugddx <[email protected]>

Author: liugddx

vector-stores/spring-ai-chroma-store/src/main/java/org/springframework/ai/chroma/vectorstore/ChromaApi.java

@@ -28,10 +28,14 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import org.springframework.ai.chroma.vectorstore.ChromaApi.QueryRequest.Include;
 import org.springframework.ai.chroma.vectorstore.common.ChromaApiConstants;
 import org.springframework.ai.util.json.JsonParser;
 import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.MediaType;
 import org.springframework.http.client.support.BasicAuthenticationInterceptor;
 import org.springframework.lang.Nullable;
@@ -52,6 +56,8 @@
  */
 public class ChromaApi {
 
+	private static final Logger logger = LoggerFactory.getLogger(ChromaApi.class);
+
 	public static Builder builder() {
 		return new Builder();
 	}
@@ -136,12 +142,15 @@ public Tenant getTenant(String tenantName) {
 				.retrieve()
 				.body(Tenant.class);
 		}
-		catch (HttpServerErrorException | HttpClientErrorException e) {
-			String msg = this.getErrorMessage(e);
-			if (String.format("Tenant [%s] not found", tenantName).equals(msg)) {
+		catch (HttpClientErrorException e) {
+			if (e.getStatusCode() == HttpStatus.NOT_FOUND) {
+				logger.debug("Tenant [{}] does not exist, returning null", tenantName);
 				return null;
 			}
-			throw new RuntimeException(msg, e);
+			throw new RuntimeException(this.getErrorMessage(e), e);
+		}
+		catch (HttpServerErrorException e) {
+			throw new RuntimeException(this.getErrorMessage(e), e);
 		}
 	}
 
@@ -165,12 +174,15 @@ public Database getDatabase(String tenantName, String databaseName) {
 				.retrieve()
 				.body(Database.class);
 		}
-		catch (HttpServerErrorException | HttpClientErrorException e) {
-			String msg = this.getErrorMessage(e);
-			if (msg.startsWith(String.format("Database [%s] not found.", databaseName))) {
+		catch (HttpClientErrorException e) {
+			if (e.getStatusCode() == HttpStatus.NOT_FOUND) {
+				logger.debug("Database [{}] in tenant [{}] does not exist, returning null", databaseName, tenantName);
 				return null;
 			}
-			throw new RuntimeException(msg, e);
+			throw new RuntimeException(this.getErrorMessage(e), e);
+		}
+		catch (HttpServerErrorException e) {
+			throw new RuntimeException(this.getErrorMessage(e), e);
 		}
 	}
 
@@ -226,12 +238,16 @@ public Collection getCollection(String tenantName, String databaseName, String c
 				.retrieve()
 				.body(Collection.class);
 		}
-		catch (HttpServerErrorException | HttpClientErrorException e) {
-			String msg = this.getErrorMessage(e);
-			if (String.format("Collection [%s] does not exists", collectionName).equals(msg)) {
+		catch (HttpClientErrorException e) {
+			if (e.getStatusCode() == HttpStatus.NOT_FOUND) {
+				logger.debug("Collection [{}] in database [{}] and tenant [{}] does not exist, returning null",
+						collectionName, databaseName, tenantName);
 				return null;
 			}
-			throw new RuntimeException(msg, e);
+			throw new RuntimeException(this.getErrorMessage(e), e);
+		}
+		catch (HttpServerErrorException e) {
+			throw new RuntimeException(this.getErrorMessage(e), e);
 		}
 	}