Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in SDK Client #342

Closed
rafalcymerys opened this issue Aug 4, 2022 · 0 comments · Fixed by #343
Closed

Fix error handling in SDK Client #342

rafalcymerys opened this issue Aug 4, 2022 · 0 comments · Fixed by #343

Comments

@rafalcymerys
Copy link
Member

rafalcymerys commented Aug 4, 2022 •
edited by rafalkosla101
Loading

Spree errors are not parsed properly - when getting any bad request(404 etc.) errors are parsed to Error type and not FetchError which should be then parsed once more to a proper Spree error. Some other modules that use SDK may not work properly since the format changed. We should fix it to prevent any further issues.
@rafalkosla101 rafalkosla101 linked a pull request Aug 5, 2022 that will close this issue
Fix error parsing #343
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error parsing spree/spree-api-v2-js-sdk
1 participant
@rafalcymerys