Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note bars are drawn to different positions w.r.t. generated midi #147

Open
YasarYY opened this issue Oct 27, 2024 · 5 comments
Open

Note bars are drawn to different positions w.r.t. generated midi #147

YasarYY opened this issue Oct 27, 2024 · 5 comments

Comments

@YasarYY
Copy link

YasarYY commented Oct 27, 2024

Describe the bug
After transcription, note bars are drawn to an html canvas for visualization. When midi file is exported and opened at another software, notes are drawn at different positions. At Basic Pitch, note bars are drawn to ~1.2 higher note positions w.r.t. generated midi.

To Reproduce

  1. Transcript a sample at Basic Pitch.
  2. See note bars' positions.
  3. Export midi file.
  4. Open downloaded midi file at another software (i.e. onlinesequencer.net)
  5. See note bars' positions are about 1 note lower.

Expected behavior
Note bars' positions are the same both at Basic Pitch and at another software.

Screenshots
Basic Pitch:
basic-pitch

Online Sequencer:
online-sequencer

Desktop:

  • OS: Windows 11
  • Browser: Google Chrome
  • Version: 130.0.6723.70 (Official Build) (64-bit)

Additional context
To my rookie ears, note bars drawn at Basic Pitch are not the correct ones.

@emmathesaw
Copy link

Hello! I am planning on looking into this issue and update you if I have any further clarification questions or successes.

@marcelofg55
Copy link

marcelofg55 commented Dec 1, 2024

I can confirm that the MIDI file contains the right notes, and the html canvas notes are wrong (they are 1 semitone higher than expected).

@emmathesaw
Copy link

I can confirm that the MIDI file contains the right notes, and the html canvas notes are wrong (they are 1 semitone higher than expected).

Is this something that can be fixed in the provided source code in the GitHub?

@drubinstein
Copy link
Contributor

Unfortunately, the code for rendering the UI is internal to Spotify and can only be changed by someone at Spotify. https://github.com/spotify/basic-pitch-ts only covers the inference in typescript. All typescript/web related issues should be posted there.

@YasarYY
Copy link
Author

YasarYY commented Dec 2, 2024

So opening this issue at basic-pitch-ts repo will not help either? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants