Inverted condition for hasStubs to fix bug (#18)

bdrelling · web-flow · commit 8066a4e80fff · 2019-10-15T16:45:37.000-05:00
diff --git a/Sources/Sham/MockService.swift b/Sources/Sham/MockService.swift
@@ -29,7 +29,7 @@ public class MockService {
 
     /// Whether or not there are any stubbed response.
     public var hasStubs: Bool {
-        return self.stubbedData.isEmpty
+        return !self.stubbedData.isEmpty
     }
 
     // MARK: - Methods
diff --git a/Tests/ShamTests/Tests/MockServiceTests.swift b/Tests/ShamTests/Tests/MockServiceTests.swift
@@ -78,7 +78,7 @@ final class MockServiceTests: XCTestCase {
 
         let hasData = MockService.shared.hasStub(for: .post(self.fullURL))
 
-        XCTAssertFalse(MockService.shared.hasStubs)
+        XCTAssertTrue(MockService.shared.hasStubs)
         XCTAssertFalse(hasData)
     }
 
@@ -88,7 +88,7 @@ final class MockServiceTests: XCTestCase {
 
         let hasData = MockService.shared.hasStub(for: self.schemeOnlyURL)
 
-        XCTAssertTrue(MockService.shared.hasStubs)
+        XCTAssertFalse(MockService.shared.hasStubs)
         XCTAssertFalse(hasData)
     }
 
@@ -98,7 +98,7 @@ final class MockServiceTests: XCTestCase {
 
         let hasData = MockService.shared.hasStub(for: self.queryOnlyURL)
 
-        XCTAssertTrue(MockService.shared.hasStubs)
+        XCTAssertFalse(MockService.shared.hasStubs)
         XCTAssertFalse(hasData)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class MockService {`
`29`	`29`
`30`	`30`	`/// Whether or not there are any stubbed response.`
`31`	`31`	`public var hasStubs: Bool {`
`32`		`- return self.stubbedData.isEmpty`
	`32`	`+ return !self.stubbedData.isEmpty`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// MARK: - Methods`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ final class MockServiceTests: XCTestCase {`
`78`	`78`
`79`	`79`	`let hasData = MockService.shared.hasStub(for: .post(self.fullURL))`
`80`	`80`
`81`		`- XCTAssertFalse(MockService.shared.hasStubs)`
	`81`	`+ XCTAssertTrue(MockService.shared.hasStubs)`
`82`	`82`	`XCTAssertFalse(hasData)`
`83`	`83`	`}`
`84`	`84`
`@@ -88,7 +88,7 @@ final class MockServiceTests: XCTestCase {`
`88`	`88`
`89`	`89`	`let hasData = MockService.shared.hasStub(for: self.schemeOnlyURL)`
`90`	`90`
`91`		`- XCTAssertTrue(MockService.shared.hasStubs)`
	`91`	`+ XCTAssertFalse(MockService.shared.hasStubs)`
`92`	`92`	`XCTAssertFalse(hasData)`
`93`	`93`	`}`
`94`	`94`
`@@ -98,7 +98,7 @@ final class MockServiceTests: XCTestCase {`
`98`	`98`
`99`	`99`	`let hasData = MockService.shared.hasStub(for: self.queryOnlyURL)`
`100`	`100`
`101`		`- XCTAssertTrue(MockService.shared.hasStubs)`
	`101`	`+ XCTAssertFalse(MockService.shared.hasStubs)`
`102`	`102`	`XCTAssertFalse(hasData)`
`103`	`103`	`}`
`104`	`104`