fix: Add standard 'dnslookup' to ignored lookups list #456
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'dnslookup' command is a standard external lookup provided by default in Splunk Enterprise. This commit adds it to the LOOKUPS_TO_IGNORE set in 'contentctl/objects/lookup.py'. This prevents validation errors during the build process when detections reference this lookup, as it does not need to be packaged with the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
dnslookupcommand to theLOOKUPS_TO_IGNORElist incontentctl/objects/lookup.py.Motivation and Context
dnslookupis a standard external lookup command provided by default in Splunk Enterprise. Currently,contentctlraises a validation error if a detection uses this lookup, as it expects all lookups to be either defined within the app or explicitly ignored.By adding it to the ignore list, we prevent false positive validation failures for detections that rely on this standard Splunk functionality.
Changes
contentctl/objects/lookup.py: Added"dnslookup"to theLOOKUPS_TO_IGNOREset.