Fix javadocs breaking build (#91)

Author: lwander

halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/problem/Problem.java

@@ -57,7 +57,9 @@ public enum Severity {
   final private NodeFilter filter;
 
   /**
-   * Provides a human-readable filter interpretation
+   * Provides a human-readable filter interpretation.
+   *
+   * @return the name of the filter in a human-readable format.
    */
   public String getFilterTitle() {
     if (filter != null) {

halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/appengine/AppengineAccount.java

@@ -19,8 +19,10 @@
 import com.netflix.spinnaker.halyard.config.model.v1.node.LocalFile;
 import com.netflix.spinnaker.halyard.config.model.v1.providers.google.CommonGoogleAccount;
 import lombok.Data;
+import lombok.EqualsAndHashCode;
 
 @Data
+@EqualsAndHashCode(callSuper = false)
 public class AppengineAccount extends CommonGoogleAccount {
   private String serviceAccountEmail;
   private String localRepositoryDirectory;

halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/google/CommonGoogleAccount.java

@@ -19,8 +19,10 @@
 import com.netflix.spinnaker.halyard.config.model.v1.node.Account;
 import com.netflix.spinnaker.halyard.config.model.v1.node.LocalFile;
 import lombok.Data;
+import lombok.EqualsAndHashCode;
 
 @Data
+@EqualsAndHashCode(callSuper = false)
 public class CommonGoogleAccount extends Account {
   private String project;
   @LocalFile private String jsonPath;

halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/services/v1/LookupService.java

@@ -36,7 +36,7 @@ public class LookupService {
    * Given a node filter and a node type, find all nodes that match both the filter and the type of the Node.
    * @param filter is the filter to lookup by.
    * @param clazz is the class of the node type we want to find.
-   * @return
+   * @return the nodes matching the filter and clazz.
    */
   public List<Node> getMatchingNodesOfType(NodeFilter filter, Class<? extends Node> clazz) {
     Halconfig halconfig = parser.getHalconfig(true);

halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/provider/v1/ProviderInterface.java

@@ -60,6 +60,8 @@ public abstract class ProviderInterface<T extends Account> {
   Map<String, SpinnakerProfile> componentMap = null;
 
   /**
+   * @param details are the deployment details for the current deployment.
+   * @param artifact is the artifact who's version to fetch.
    * @return the docker image/debian package/etc... for a certain profile.
    */
   abstract protected String componentArtifact(DeploymentDetails<T> details, SpinnakerArtifact artifact);

halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/profile/SpinnakerProfile.java

@@ -42,7 +42,7 @@
 import java.util.stream.Collectors;
 
 /**
- * A profile is a specialization of an artifact by means of feature flipping in .js & .yml
+ * A profile is a specialization of an artifact by means of feature flipping in .js and .yml
  * files.
  */
 abstract public class SpinnakerProfile {