Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: JSON.mapping -> JSON::Serializable #19

Closed
caspiano opened this issue May 21, 2020 · 1 comment · Fixed by #34
Closed

refactor: JSON.mapping -> JSON::Serializable #19

caspiano opened this issue May 21, 2020 · 1 comment · Fixed by #34
Assignees
@dukenguyenxyz

Comments

@caspiano
Copy link
Contributor

caspiano commented May 21, 2020 •
edited
Loading

Currently, active-model generates a JSON.mapping off the specified attributes.
Moving to an annotation flow would improve interop with other libraries and frameworks.

This change would be a good part of the progress towards solving spider-gazelle/rethinkdb-orm#2
@dukenguyenxyz dukenguyenxyz mentioned this issue Oct 26, 2020
Closed
@dukenguyenxyz
Copy link
Contributor

The PR to resolve this issue (#26) is currently blocked by the following issue which I already made a PR (crystal-lang/crystal#10265)

@dukenguyenxyz dukenguyenxyz changed the title Refactor to JSON::Serializable refactor: JSON.mapping -> JSON::Serializable Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Closed
@dukenguyenxyz dukenguyenxyz self-assigned this Jan 19, 2021
@caspiano caspiano mentioned this issue Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dukenguyenxyz dukenguyenxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@caspiano @dukenguyenxyz