qt: followup #10277: change icons depending on context #10300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the icons of the "Tools" button to the icon of the tab in which the button is located so it is visible that the available Tools are dependent on the context.
Member
|
I guess it is subjective but I mildly prefer the "preferences" icon. Though perhaps it's just what I got "used to".
Well, yes, good point... idk, no strong preference either way. |
Member
Author
|
Yeah i also feel like the "preferences" icon approach looks a bit cleaner. |
Member
|
I wanted a visual hint that the content of the drop-down is not the same in every tab. |
Member
|
Note: ideally, I want the toolbar to be configurable: It would be possible to drag an icon from the drop-down to the toolbar, and it would add a direct button to the toolbar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the icons of the "Tools" button to the same icon as the tab in which the button is located to make it visible that the available tools are dependent on the buttons context.