Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 429: analyse/lint and format script #435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue 429: analyse/lint and format script #435

wants to merge 1 commit into from

Conversation

thomasmerz
Copy link

This PR fixes #429 by these changes:

  👷 add a fancy GitHub action for 'shellcheck' and 'shfmt'
  👷 moved 'shellcheck' and 'check indentation' to new GitHub Action
  🚨 fix 'shellcheck' warnings
  🚨 fix 'shfmt' warnings

Contrary to my expectations I had to fix some warnings in spectre-meltdown-checker.sh which finalize in some minor changes. 🤷🏻‍♂️

Please have a look at my latest GitHub Action run in my forked repo:

image

image

image

@thomasmerz
Issue 429: analyse/lint and format script
f422c8f 
  👷 add a fancy GitHub action for 'shellcheck' and 'shfmt'
  👷 moved 'shellcheck' and 'check indentation' to new GitHub Action
  🚨 fix 'shellcheck' warnings
  🚨 fix 'shfmt' warnings
@thomasmerz thomasmerz marked this pull request as ready for review March 30, 2022 13:53
@thomasmerz
Copy link
Author

BTW:
I use https://github.com/itspriddle/vim-shellcheck and https://github.com/z0mbix/vim-shfmt for local checking while writing/fixing code and https://github.com/nektos/act for a final local check running in a local GitHub Action in docker containers on my linux machine (which makes some trouble with the docker-in-docker steps on my linux machine 🤷🏻‍♂️ ).

@thomasmerz
Copy link
Author

I also added some example GitHub Actions for a bad linting/shell syntax and a good (fixed) one.

@thomasmerz thomasmerz mentioned this pull request May 27, 2022
Open
@thomasmerz
Copy link
Author

Hey @speed47 , can you please review this PR? Thank you.

@thomasmerz
Copy link
Author

Hi @speed47 , before I start to resolve conflicts… are you fine with an GitHub Action based analyse/lint tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve code quality by using standard tools to format and analyse for PRs
1 participant
@thomasmerz