Skip to content

Faulty buffer write operations #52

@BridgeAR

Description

@BridgeAR

Right now the framer has multiple buffer.writeUInt32BE calls. In case priority.exclusive is truthy it can pass in a negative value because 0x80000000 | undefined === -(2 ** 31).

This currently works because the buffer write operation will overflow and safe that value. That will not be possible in future versions anymore.

Right now the test should generate priority request frame will result in such a case. I tried to fix it but I am not sure what the right solution should be. Ping @indutny

Refs: nodejs/node#18395

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions