Why not a facade?

[leobeal]

Hi :)
I found this package today and I'm already switching over from my custom settings implementation :D . Thank you for that!

One thing I noticed is that it doesn't use facades. I think using something like Settings::get('general','currency') could be useful.

I tried it out by making a facade for my GeneralSettings, and it works fine, though it does mean you have to create the facade manually for each class.

Happy to hear your thought, and thanks again!

class GeneralSettings extends Settings
{
   ...

   public static function group(): string
    {
        return 'general';
    }

    public function get($name)
    {
        return parent::__get($name);
    }
}


class GeneralSettingsFacade extends Facade
{
    protected static function getFacadeAccessor(): string
    {
        return GeneralSettings::class;
    }
}

//usage

SettingsFacade::get('currency');

[rubenvanassche]

The whole idea of settings is to make them strongly typed and use dependency injection for that, by using facades we kinda lose that.

In the end users can create their own facades like you've shown so everything is possible. But I don't think facades should be part of the package.

[leobeal]

Makes a lot of sense! Thank you for your feedback @rubenvanassche