Skip to content

Commit 372af63

Browse files
committed
fix tests
1 parent 6578b19 commit 372af63

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ use Spatie\RobotsMiddleware\RobotsMiddleware;
3232

3333
class MyRobotsMiddleware extends RobotsMiddleware
3434
{
35-
protected function shouldIndex(Request $request) : bool
35+
/**
36+
* @return string|bool
37+
*/
38+
protected function shouldIndex(Request $request)
3639
{
3740
return $request->segment(1) !== 'admin';
3841
}

src/RobotsMiddleware.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ protected function responseWithRobots(string $contents)
4141
return $this->response;
4242
}
4343

44-
protected function shouldIndex(Request $request) : bool
44+
/**
45+
* @return string|bool
46+
*/
47+
protected function shouldIndex(Request $request)
4548
{
4649
return true;
4750
}

tests/RobotsMiddlewareTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
namespace Spatie\RobotsMiddleware\Test;
44

55
use Spatie\RobotsMiddleware\InvalidIndexRule;
6-
use Spatie\RobotsMiddleware\Test\TestMiddlewares\CustomTestMiddleware;
7-
use Spatie\RobotsMiddleware\Test\TestMiddlewares\InvalidTestMiddleware;
8-
use Spatie\RobotsMiddleware\Test\TestMiddlewares\SimpleTestMiddleware;
96

107
class RobotsMiddlewareTest extends TestCase
118
{

tests/TestMiddlewares/CustomTestMiddleware.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77

88
class CustomTestMiddleware extends RobotsMiddleware
99
{
10-
protected function shouldIndex(Request $request) : string
10+
/**
11+
* @return string|bool
12+
*/
13+
protected function shouldIndex(Request $request)
1114
{
1215
if ($request->segment(1) === 'custom-tag') {
1316
return 'nofollow';

tests/TestMiddlewares/InvalidTestMiddleware.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77

88
class InvalidTestMiddleware extends RobotsMiddleware
99
{
10+
/**
11+
* @return string|bool
12+
*/
1013
protected function shouldIndex(Request $request) : array
1114
{
1215
return [];

tests/TestMiddlewares/SimpleTestMiddleware.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77

88
class SimpleTestMiddleware extends RobotsMiddleware
99
{
10-
protected function shouldIndex(Request $request) : bool
10+
/**
11+
* @return string|bool
12+
*/
13+
protected function shouldIndex(Request $request)
1114
{
1215
return $request->segment(1) !== 'go-away';
1316
}

0 commit comments

Comments
 (0)