Skip to content

Fix compiler warnings... #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulZC opened this issue May 6, 2021 · 1 comment · Fixed by #38
Closed

Fix compiler warnings... #37

PaulZC opened this issue May 6, 2021 · 1 comment · Fixed by #38

Comments

@PaulZC
Copy link
Contributor

PaulZC commented May 6, 2021 •
edited
Loading

Check library and examples for compiler warnings reported by NES
@PaulZC
Copy link
Contributor Author

PaulZC commented May 6, 2021 •
edited
Loading

The ESP32 compiler finds these warnings...:

C:\Users\pc235\Documents\Arduino\libraries\SparkFun_Micro_OLED_Arduino_Library\src\SFE_MicroOLED.cpp:628:9: warning: comparison is always false due to limited range of data type [-Wtype-limits]
  if ((x < 0) || (x >= LCDWIDTH) || (y < 0) || (y >= LCDHEIGHT))

C:\Users\pc235\Documents\Arduino\libraries\SparkFun_Micro_OLED_Arduino_Library\src\SFE_MicroOLED.cpp:628:39: warning: comparison is always false due to limited range of data type [-Wtype-limits]
  if ((x < 0) || (x >= LCDWIDTH) || (y < 0) || (y >= LCDHEIGHT))

@PaulZC PaulZC linked a pull request May 8, 2021 that will close this issue
v1.3.3 - fix compiler warnings #38
Merged
@PaulZC PaulZC closed this as completed in #38 May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.3.3 - fix compiler warnings sparkfun/SparkFun_Micro_OLED_Arduino_Library
1 participant
@PaulZC