Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memmap/copy_arrays/lazy_load options not passed through from DataModel API #398

Open
braingram opened this issue Feb 11, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@braingram
Copy link
Collaborator

xref: https://jira.stsci.edu/browse/AL-562

DataModel allows the passing of memmap to lower level routines. However, that specification does not transfer into the asdf components. In addition, the kwargs dict is allowed, to specify any extra parameters to lower level I/O routines. However, these are ignored or overridden, again not reaching the appropriate asdf methods.

As a result, the asdf component is always memmap=True, lazy_load=True, and copy_arrays=False, regardless of specification. This may be by design; unclear what effect these have with asdf-in-FITS.

The ticket mentions some work towards this effort from ~3 years ago (not linking here to avoid names).

@braingram braingram self-assigned this Feb 11, 2025
@braingram
Copy link
Collaborator Author

Although several of these options have changed I believe the issue with the kwargs still applies.

@braingram braingram added the bug Something isn't working label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant