Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify merge_property_trees #366

Open
braingram opened this issue Nov 20, 2024 · 1 comment
Open

Simplify merge_property_trees #366

braingram opened this issue Nov 20, 2024 · 1 comment
Labels
question Further information is requested

Comments

@braingram
Copy link
Collaborator

As commented in the code:

stdatamodels/src/stdatamodels/schema.py

Line 175 in ab0cba5

# TODO: Simplify?

the merge_property_trees function could likely be simplified with an eye towards improved readability and maintenance.
@braingram braingram mentioned this issue Nov 20, 2024
Merged
5 tasks
@emolter emolter added the question Further information is requested label Feb 11, 2025
@braingram
Copy link
Collaborator Author

This issue needs some additional explanation of what simplification is needed.

This simplification should have no changes to the result of the function but improve the readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@braingram @emolter