Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for residual_fringe step #9233

Open
stscijgbot-jp opened this issue Feb 27, 2025 · 1 comment
Open

Add test coverage for residual_fringe step #9233

stscijgbot-jp opened this issue Feb 27, 2025 · 1 comment

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3900 was created on JIRA by Melanie Clarke:

Since the residual fringe step is off by default, it is not covered by standard MIRI MRS spec2 regression tests.  We should add a test that turns the step on, to make sure we catch regressions.

Unit test coverage for this module is also currently very minimal.  We should add some tests to make sure this step continues to work.

Since this step is not currently covered at all, it looks like it was overlooked in testing for numpy 2 compatibility.  It requires BayesicFitting>=3.2.2 to run with numpy>2; the current minimum pin in jwst is 3.0.1.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant